bito-code-review[bot] commented on code in PR #43729:
URL: https://github.com/apache/superset/pull/43729#discussion_r3897168535
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts:
##########
@@ -2877,6 +2877,77 @@ test('boundary label alignment is dropped when the
orientation moves the time ax
expect(horizontal.axisLabel.alignMaxLabel).toBeUndefined();
// The boundary labels themselves stay forced in both orientations.
+
+describe('xAxisLabelInterval string "0" is converted to number 0', () => {
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Nested describe in test</b></div>
<div id="fix">
This `describe` block is nested inside the `test('boundary label alignment
is dropped...')` callback (which opens at line 2843 and closes at line 2955).
jest-circus throws `Cannot nest describe inside a test`, so this file fails to
run. Move the block to module scope and relocate the `monthData` fixture it
references (currently scoped to the callback).
</div>
</div>
<small><i>Code Review Run #ea91a1</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
