fparodimoraes commented on issue #43728: URL: https://github.com/apache/superset/issues/43728#issuecomment-5482942204
Thanks for digging into this, @dosu! Two follow-ups: 1. Confirmed the `.js` vs `.ts` reference is just your knowledge base pointing at an older commit -- as of `master`, the plugin has moved (via #41729) from `legacy-plugin-chart-partition/src/Partition.ts` to `plugin-chart-partition/src/Partition.ts`. I diffed the current file against the version this issue was originally filed against: identical except for an unrelated `sanitizeHtml` hardening change, so the bug and this fix apply unchanged at the new path. 2. On `transformData.ts`: confirmed its main aggregation path (`not_time`/`agg_sum`/`agg_mean`) does independently reproduce the same ancestor-path-array convention for deeper nodes, while its time-diff/factor path already extracts a plain leaf string. Since `Partition.ts` is the single shared renderer for both the legacy `explore_json` path and the new v1 API path, normalizing `name` there (rather than in `transformData.ts`) fixes both call sites with one change, and is a safe no-op wherever a plain string is already provided. Opened #43731 against the current `plugin-chart-partition/src/Partition.ts` with this fix, plus updated the `PartitionDataNode` type and `PropTypes` declarations to reflect the real `string | string[]` contract. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
