rlei-odes commented on code in PR #43660:
URL: https://github.com/apache/superset/pull/43660#discussion_r3897519356
##########
superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx:
##########
@@ -517,6 +517,17 @@ export const gridlines: ControlSetItem = {
},
};
+export const valueAxisLabels: ControlSetItem = {
+ name: 'valueAxisLabels',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Value axis labels'),
+ default: true,
Review Comment:
Hey Evan,
Good call on using our human brains to second-guess the bot brains. I try to
do that frequently, but it has its limits...
Here, the logic is designed to do what you are assessing, which is to
preserve the logic of the isMicroChart as it is, regardless of the state of the
new checkbox. So no new behaviour in that regard is introduced.
I confirmed this visually too, both in ticked and unticked state, making a
chart really small in height hides the axis labels:
<img width="828" height="127" alt="smallchart"
src="https://github.com/user-attachments/assets/d616448f-9503-40c2-b52c-8869090c0e36";
/>
Wether this a sensible boundary is another topic.
The ticks and gridlines trigger at compactChartHeight, which is larger, so
they disappear earlier:
microChartHeight = 60, compactChartHeight = 100
Also confirmed visually.
Hope that helps,
best regards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
