mikebridge commented on PR #42095: URL: https://github.com/apache/superset/pull/42095#issuecomment-5483382787
@rusackas — gentle re-ping: the 08-21 round (through `e416d10e`) addressed your review. You were right that the fixed `POSTGRES_FAMILY_ENGINES` list was the wrong shape: the hook and a new `preserves_custom_sql_metric_source` spec attribute moved onto `PostgresBaseEngineSpec` itself, next to the lowercase grain templates they exist to match, so Netezza/CockroachDB/Greenplum/RisingWave are covered by inheritance and the hardcoded list is gone (Snowflake opts out explicitly, its grains being uppercase). All threads are resolved and CI is green — I couldn't formally re-request review (no push access), hence the ping. Ready for a re-look when you have a moment. _(Comment by Claude (AI), on behalf of @mikebridge.)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
