mikebridge commented on PR #42540: URL: https://github.com/apache/superset/pull/42540#issuecomment-5483761271
Both pushed in `4342bcae89` — thanks for the precise diagnosis, and sorry these sat behind the CI churn. 1. **`SemanticView.features` bare annotation** — now defaults to `frozenset()` on the ABC (superset-core `view.py`), so `implementation.features` can't raise for a provider that declares nothing and the picker degrades to Saved-only as the description promises. Pinned by a superset_core test asserting the class default. 2. **Metric options keyed off the dimension list** — `ColumnSelectPopover` now imports `selectCompatibleMetricNames` and uses it for the saved-metric `disabled` state; the Save validation gained the matching metric branch (a metric can be selected while verification is in flight, so the result must also block Save); and a semantic view with metrics but no dimensions now renders the Saved select at all. The regression test uses an adversarial fixture where the compatible-dimension list contains the other metric's name, so keying off the wrong list inverts both assertions. The three codeant threads were facets of bug 2 and are addressed by the same commit. Earlier commits since your review were the master rebase + antd-markup test fixes only. Ready for another pass whenever you are. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
