aminghadersohi opened a new pull request, #43737: URL: https://github.com/apache/superset/pull/43737
### SUMMARY Adds production-quality typed MCP creation and iteration support for Superset's existing ECharts Gantt visualization. - Introduces a discriminated `gantt` config grounded in the frontend `controlPanel`, `buildQuery`, and `transformProps` contracts, including temporal start/end fields, category, series/subcategories, tooltips, ordering, filters/time range, row limits, and presentation controls. - Adds dataset-aware validation/normalization, bounded native `gantt_chart` form-data adaptation, exact typed-to-native mapping, registry/schema/resource/tool exposure, and shared chart-aware query construction for generate/update/query/compile/cached-preview paths. - Preserves native Gantt presentation state during saved and cached preview updates. - Adds faithful saved and unsaved Vega-Lite interval-bar previews with conservative malformed/missing-result errors and valid empty-result handling. - Adds focused coverage based on the repository's saved Gantt example, including schema/discriminator exposure, mapping/query shape, native round trips, validation, preview behavior, aliases, and regression wiring. Shortcut: https://app.shortcut.com/preset/story/119155 Agor worktree: https://agor.sandbox.preset.zone/ui/w/01a059c3113b72ae84b8b332/ Existing Gantt layout-fix PRs #43189, #43299, and #39137 are unrelated to this MCP typed-creation work and are not modified or duplicated here. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; this change adds MCP schemas, mapping, validation, query, and preview support without changing the frontend Gantt UI. ### TESTING INSTRUCTIONS ```bash # SQLAlchemy 2.0.52 environment python -m pytest -q tests/unit_tests/mcp_service/chart/ # 1382 passed python -m pytest -q tests/unit_tests/mcp_service/test_mcp_e2e_smoke.py::test_tools_call_health_check_over_real_asgi_transport # 1 passed pre-commit run # mypy, Ruff format/check, pylint, and all applicable hooks pass python -m compileall -q superset/mcp_service/chart tests/unit_tests/mcp_service/chart/test_gantt_chart.py git diff --check git diff --cached --check ``` The broader `tests/unit_tests/mcp_service/` run completed 3,715 tests successfully; its one environment-dependent health/version assertion passed when rerun after installing the repository editable package metadata. ### ADDITIONAL INFORMATION - [x] Has associated issue: [SC-119155](https://app.shortcut.com/preset/story/119155) - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
