sadpandajoe commented on code in PR #43407: URL: https://github.com/apache/superset/pull/43407#discussion_r3901256616
########## superset-websocket/utils/README.md: ########## @@ -27,7 +27,8 @@ The Express web application in `client-ws-app` is provided for testing the WebSo ## Load testing script -The `loadtest.js` script is provided to populate the Redis streams with event data. +The `loadtest.js` script is provided to publish realtime event data to the Review Comment: This leaves the documented load-test command publishing only to the retired `entity-changes:task` and `task-status` channels, while the server now subscribes only to `realtime`, so it cannot exercise browser delivery. Should `loadtest.js` publish the new realtime envelopes instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
