fitzee commented on PR #43633: URL: https://github.com/apache/superset/pull/43633#issuecomment-5490854145
@mikebridge @aminghadersohi Thanks for the detailed review. I pushed `447693ad99` and addressed the broader blocking feedback rather than adding an Ace remount workaround: - Certification is hydrated into dedicated editor state and merged into the latest raw Extra only at save when the dedicated fields were edited. This removes the competing-writers design and keeps direct Extra edits authoritative otherwise. - Certification updates use functional state; `Fieldset` also advances its item ref synchronously so sibling debounced commits in one React batch cannot drop each other. - Malformed/non-object Extra disables both certification controls with a corrective message. - Clearing removes only the supported certification keys; unknown nested keys survive. Unchanged values preserve the original raw string/format and an empty no-op remains empty. - Real 500 ms sleeps were replaced with a same-debounce-window modal test plus an editor-level committed-state race test. Edge coverage includes unknown nested keys, details-only, empty-string clear, malformed/non-object values, and no-op formatting. - The section is next to Extra, whose help text directs users to the dedicated controls. - The PR title is now `feat(dataset): expose dataset certification controls` and “Introduces new feature or API” is checked. Focused validation: 4 suites / 30 tests passed; staged pre-commit passed including formatting, lint/custom rules, stylelint, and targeted TypeScript checking. I could not add an updated screenshot because `localhost:8088/health` is not available in this worktree; the PR retains explicit before/after text and expanded manual steps. I replied to and resolved all seven inline threads with the specific change/test for each. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
