codeant-ai-for-open-source[bot] commented on code in PR #43777:
URL: https://github.com/apache/superset/pull/43777#discussion_r3906997072
##########
superset/semantic_layers/models.py:
##########
@@ -322,6 +332,99 @@ def get_query_result(self, query_object: QueryObject) ->
QueryResult:
def get_query_str(self, query_obj: QueryObjectDict) -> str:
return "Not implemented for semantic layers"
+ @property
+ def normalize_columns(self) -> bool:
+ """Dimension names are provider-verbatim; nothing to (de)normalize.
+
+ Exists for the datasource values endpoint, which reads it before
+ requesting filter-value suggestions.
+ """
+ return False
+
+ def values_for_column(
+ self,
+ column_name: str,
+ limit: int = 10000,
+ denormalize_column: bool = False, # pylint: disable=unused-argument
+ array_elements: bool = False, # pylint: disable=unused-argument
Review Comment:
**Suggestion:** `array_elements` is ignored, so array dimensions return
whole arrays instead of individual values for Contains any and Contains all
suggestions. [api mismatch]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9e6badb490714a0fbb4d93c420266175&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9e6badb490714a0fbb4d93c420266175&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/semantic_layers/models.py
**Line:** 349:349
**Comment:**
*Api Mismatch: `array_elements` is ignored, so array dimensions return
whole arrays instead of individual values for Contains any and Contains all
suggestions.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43777&comment_hash=87a1ab52dc298b1368ff6dc54c1572b441cc40f034deed3771b09bbe216ba8f3&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43777&comment_hash=87a1ab52dc298b1368ff6dc54c1572b441cc40f034deed3771b09bbe216ba8f3&reaction=dislike'>๐</a>
##########
superset/semantic_layers/models.py:
##########
@@ -322,6 +332,99 @@ def get_query_result(self, query_object: QueryObject) ->
QueryResult:
def get_query_str(self, query_obj: QueryObjectDict) -> str:
return "Not implemented for semantic layers"
+ @property
+ def normalize_columns(self) -> bool:
+ """Dimension names are provider-verbatim; nothing to (de)normalize.
+
+ Exists for the datasource values endpoint, which reads it before
+ requesting filter-value suggestions.
+ """
+ return False
+
+ def values_for_column(
+ self,
+ column_name: str,
+ limit: int = 10000,
+ denormalize_column: bool = False, # pylint: disable=unused-argument
+ array_elements: bool = False, # pylint: disable=unused-argument
+ search: str | None = None,
+ ) -> list[Any]:
+ """Return the distinct values of one dimension for filter suggestions.
+
+ Delegates to the provider ABC's purpose-built ``get_values`` โ an
+ abstract member every provider implements, consumed here for the
+ first time. ``search`` narrows at the provider with a containment
+ ``LIKE`` filter on the dimension, so values beyond the first page are
+ findable. Two documented parity gaps with datasets, both inherent to
+ the standard filter model: case sensitivity follows the provider's
+ collation (no case-folding operator), and ``%``/``_`` in the search
+ term act as wildcards (no portable escape declaration; over-matching
+ is the safe failure for suggestions). A provider that rejects the
+ narrowing filter โ a non-text dimension, say โ falls back to the
+ unfiltered bounded page with a logged warning rather than an error.
+
+ ``get_values`` takes no limit or order, so both are applied here:
+ sorted ascending (nulls first) and then truncated, so the page is
+ deterministic and not an arbitrary provider-order subset.
+ ``denormalize_column`` and ``array_elements`` are dataset concepts
+ (dialect name denormalization, array-element explosion) with no
+ semantic-view counterpart; they are accepted for endpoint signature
+ compatibility and ignored.
+
+ Raises ``KeyError`` for a name that is not a dimension of the view โ
+ a metric name included โ which the endpoint reports as the caller's
+ error naming the column, exactly as a dataset does.
+ """
+ dimensions = {
+ dimension.name: dimension for dimension in self._unique_dimensions
+ }
+ if column_name not in dimensions:
+ raise KeyError(column_name)
+ dimension = dimensions[column_name]
+
+ if search:
+ narrowing = Filter(
+ type=PredicateType.WHERE,
+ column=dimension,
+ operator=Operator.LIKE,
+ value=f"%{search}%",
+ )
+ try:
+ result = self.implementation.get_values(dimension, {narrowing})
+ except Exception: # pylint: disable=broad-exception-caught
+ # The narrowing filter is best-effort: a provider that cannot
+ # apply it must degrade to the bounded first page (the picker
+ # still narrows within it), never to an error โ but say so,
+ # or the degradation is the next silent failure.
+ logger.warning(
+ "Semantic view %s rejected the value-search filter on "
+ "dimension %s; returning the unfiltered page",
+ self.uuid,
+ dimension.name,
+ exc_info=True,
+ )
+ result = self.implementation.get_values(dimension, None)
+ else:
+ result = self.implementation.get_values(dimension, None)
+
+ # Some drivers report zero rows as ``results is None``.
+ if result.results is None or result.results.num_rows == 0:
+ return []
+ table = stringify_extension_columns(result.results)
+ if dimension.name in table.column_names:
+ column = table.column(dimension.name)
+ elif table.num_columns == 1:
+ column = table.column(0)
+ else:
+ # A provider-contract violation is the server's fault, not the
+ # caller's; surface it rather than mislabeling it a bad column.
+ raise ValueError(
+ f"Provider result is missing the requested dimension
{dimension.name}"
+ )
+ values = column.to_pylist()
+ values.sort(key=lambda value: (value is not None, value))
+ return values[:limit]
Review Comment:
**Suggestion:** Sorting structured values such as Arrow structs produces
Python dictionaries, which cannot be ordered and raises `TypeError` before the
endpoint responds. [type error]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=987a6db570cd4d0da0b32afba217d2ac&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=987a6db570cd4d0da0b32afba217d2ac&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/semantic_layers/models.py
**Line:** 425:426
**Comment:**
*Type Error: Sorting structured values such as Arrow structs produces
Python dictionaries, which cannot be ordered and raises `TypeError` before the
endpoint responds.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43777&comment_hash=fdf5ab22f07419c62b4a031161ef3ab5e3b2c7caa052f93a929e6932df13463b&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43777&comment_hash=fdf5ab22f07419c62b4a031161ef3ab5e3b2c7caa052f93a929e6932df13463b&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
