msyavuz commented on code in PR #43719:
URL: https://github.com/apache/superset/pull/43719#discussion_r3906737319
##########
superset/datasets/api.py:
##########
@@ -1757,6 +1757,8 @@ def get_drill_info(self, pk: int, **kwargs: Any) ->
Response:
"columns.column_name",
"columns.verbose_name",
"columns.groupby",
+ "metrics.metric_name",
Review Comment:
This only takes effect for viewers who already have Drill-to-Detail —
`SliceHeaderControls/index.tsx:196` passes `!canDrillToDetail` as the hook's
`skip`, which short-circuits to an empty dataset, so a
`can_view_chart_as_table`-only user never fetches drill_info and still sees raw
names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
