fitzee opened a new pull request, #43784: URL: https://github.com/apache/superset/pull/43784
### SUMMARY Scheduled report readiness treated an AG Grid chart as rendered as soon as its generic slice container mounted, even though AG Grid had not necessarily fired `onFirstDataRendered`. This could allow screenshot capture while the grid area was still blank. Reuse the existing `_agGridFirstDataRendered` contract exposed by `ThemedAgGridReact` in all screenshot readiness predicates. Unpainted grids remain unready for standard dashboard, tiled dashboard, and standalone chart captures, and timeout diagnostics classify them as `ag_grid_unpainted`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable. This changes headless scheduled-report capture timing without changing the interactive UI. ### TESTING INSTRUCTIONS 1. Enable `AG_GRID_TABLE_ENABLED` and create a dashboard containing an AG Grid table. 2. Delay or pause AG Grid before `onFirstDataRendered` fires. 3. Execute a PNG or PDF report and confirm screenshot readiness continues polling. 4. Allow `onFirstDataRendered` to fire and confirm capture proceeds. 5. Run `pytest -q tests/unit_tests/utils/test_screenshot_utils.py`. Added unit coverage verifies the AG Grid gate is present in viewport, all-holder, tiled-report, and standalone-chart predicates, with the new diagnostic state. Local validation: - `uvx pre-commit run --files superset/utils/screenshot_utils.py tests/unit_tests/utils/test_screenshot_utils.py` passed. - Python compilation passed. - The targeted pytest command could not start locally because the host Python environment does not have Flask installed. - `pre-commit run --all-files` was also attempted; it is blocked by unrelated repository/environment failures including existing mypy errors in `lint_metadata.py`, missing frontend optional dependencies, and existing repo-wide lint findings. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Required feature flags: `AG_GRID_TABLE_ENABLED` - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
