codecov[bot] commented on PR #43805: URL: https://github.com/apache/superset/pull/43805#issuecomment-5515619389
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43805?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `58.57741%` with `99 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 66.13%. Comparing base ([`3bd4378`](https://app.codecov.io/gh/apache/superset/commit/3bd437869a68814af19408de349567702ebe740a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6ab4a1d`](https://app.codecov.io/gh/apache/superset/commit/6ab4a1de4ce29d2dae61e6a070d3f3360431cdc9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 3 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/43805?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [superset/tasks/export\_dashboard\_excel.py](https://app.codecov.io/gh/apache/superset/pull/43805?src=pr&el=tree&filepath=superset%2Ftasks%2Fexport_dashboard_excel.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdGFza3MvZXhwb3J0X2Rhc2hib2FyZF9leGNlbC5weQ==) | 21.56% | [40 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/utils/gcs.py](https://app.codecov.io/gh/apache/superset/pull/43805?src=pr&el=tree&filepath=superset%2Futils%2Fgcs.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvZ2NzLnB5) | 0.00% | [26 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/utils/s3.py](https://app.codecov.io/gh/apache/superset/pull/43805?src=pr&el=tree&filepath=superset%2Futils%2Fs3.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvczMucHk=) | 0.00% | [22 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...hboard/components/menu/DownloadMenuItems/index.tsx](https://app.codecov.io/gh/apache/superset/pull/43805?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fdashboard%2Fcomponents%2Fmenu%2FDownloadMenuItems%2Findex.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvRG93bmxvYWRNZW51SXRlbXMvaW5kZXgudHN4) | 80.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/43805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/dashboards/api.py](https://app.codecov.io/gh/apache/superset/pull/43805?src=pr&el=tree&filepath=superset%2Fdashboards%2Fapi.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | 95.45% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/43805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (3bd4378) and HEAD (6ab4a1d). Click for more details. > > <details><summary>HEAD has 60 uploads less than BASE</summary> > >| Flag | BASE (3bd4378) | HEAD (6ab4a1d) | >|------|------|------| >|python|40|3| >|presto|8|1| >|hive|8|1| >|sqlite|7|1| >|javascript|4|1| ></details> <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #43805 +/- ## =========================================== - Coverage 79.31% 66.13% -13.19% =========================================== Files 2890 2893 +3 Lines 167213 167414 +201 Branches 38718 38743 +25 =========================================== - Hits 132631 110720 -21911 - Misses 32084 54450 +22366 + Partials 2498 2244 -254 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/43805/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/43805/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.80% <31.95%> (-0.02%)` | :arrow_down: | | [javascript](https://app.codecov.io/gh/apache/superset/pull/43805/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.84% <80.00%> (+<0.01%)` | :arrow_up: | | [mysql](https://app.codecov.io/gh/apache/superset/pull/43805/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [postgres](https://app.codecov.io/gh/apache/superset/pull/43805/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [presto](https://app.codecov.io/gh/apache/superset/pull/43805/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.69% <31.95%> (-0.02%)` | :arrow_down: | | [python](https://app.codecov.io/gh/apache/superset/pull/43805/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.25% <53.60%> (-26.51%)` | :arrow_down: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/43805/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.12% <53.60%> (-0.01%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/apache/superset/pull/43805/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43805?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
