Copilot commented on code in PR #43806:
URL: https://github.com/apache/superset/pull/43806#discussion_r3920174140
##########
superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx:
##########
@@ -233,6 +233,25 @@ const defaultResizableConfig = (hideFooter: boolean |
undefined) => ({
},
});
+/** Merge caller overrides without dropping default resize-handle guards. */
+export function mergeResizableConfig(
+ hideFooter: boolean | undefined,
+ overrides: ModalProps['resizableConfig'] = {},
+) {
Review Comment:
`mergeResizableConfig` is exported, so its inferred return type becomes part
of the module’s `.d.ts` surface and may change unintentionally as
`defaultResizableConfig` evolves. Adding an explicit return type keeps the
signature stable and makes intent clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
