FrancescoCastaldi commented on code in PR #43586:
URL: https://github.com/apache/superset/pull/43586#discussion_r3922402374
##########
superset/commands/database/uploaders/base.py:
##########
@@ -168,11 +168,14 @@ def run(self) -> None:
)
)
+ catalog = self._model.get_default_catalog()
+
sqla_table = (
db.session.query(SqlaTable)
.filter_by(
table_name=self._table_name,
schema=self._schema,
+ catalog=catalog,
Review Comment:
Addressed in commit e3ed1b5. Updated the dataset lookup query in
\UploadCommand\ to be null-aware using an \or_(SqlaTable.catalog == catalog,
SqlaTable.catalog.is_(None))\ condition, ensuring legacy datasets with \catalog
IS NULL\ are properly matched and their catalog field is backfilled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
