sadpandajoe commented on code in PR #43712:
URL: https://github.com/apache/superset/pull/43712#discussion_r3928992032
##########
docs/src/data/databases.json:
##########
@@ -1741,87 +1738,6 @@
"supports_catalog": false,
"supports_dynamic_catalog": false
},
- "Ascend": {
- "time_grains": {
- "SECOND": true,
- "FIVE_SECONDS": false,
- "THIRTY_SECONDS": false,
- "MINUTE": true,
- "FIVE_MINUTES": false,
- "TEN_MINUTES": false,
- "FIFTEEN_MINUTES": false,
- "THIRTY_MINUTES": false,
- "HALF_HOUR": false,
- "HOUR": true,
- "SIX_HOURS": false,
- "DAY": true,
- "WEEK": true,
- "WEEK_STARTING_SUNDAY": false,
- "WEEK_STARTING_MONDAY": false,
- "WEEK_ENDING_SATURDAY": false,
- "WEEK_ENDING_SUNDAY": false,
- "MONTH": true,
- "QUARTER": true,
- "QUARTER_YEAR": false,
- "YEAR": true
- },
- "module": "superset.db_engine_specs.ascend",
- "limit_method": 1,
- "limit_clause": true,
- "joins": true,
- "subqueries": true,
- "alias_in_select": true,
- "alias_in_orderby": true,
- "time_groupby_inline": false,
- "alias_to_source_column": false,
- "order_by_not_in_select": true,
- "expressions_in_orderby": false,
- "cte_in_subquery": true,
- "max_column_name": null,
- "sql_comments": true,
- "escaped_colons": true,
- "masked_encrypted_extra": false,
- "column_type_mapping": false,
- "function_names": false,
- "user_impersonation": false,
- "file_upload": true,
- "get_extra_table_metadata": false,
- "dbapi_exception_mapping": false,
- "custom_errors": false,
- "dynamic_schema": false,
- "catalog": false,
- "dynamic_catalog": false,
- "ssh_tunneling": true,
- "query_cancelation": true,
- "get_metrics": false,
- "where_latest_partition": false,
- "expand_data": false,
- "query_cost_estimation": false,
- "sql_validation": false,
- "score": 38,
- "max_score": 201,
- "documentation": {
- "description": "Ascend.io is a data automation platform for building
data pipelines.",
- "logo": "ascend.webp",
- "homepage_url": "https://www.ascend.io/";,
- "categories": [
- "Cloud Data Warehouses",
- "Analytical Databases",
- "Hosted Open Source"
- ],
- "pypi_packages": ["impyla"],
- "connection_string":
"ascend://{username}:{password}@{hostname}:{port}/{database}?auth_mechanism=PLAIN;use_ssl=true",
- "category": "Other Databases"
- },
- "engine": "ascend",
- "engine_name": "Ascend",
- "engine_aliases": [],
- "default_driver": null,
- "supports_file_upload": true,
- "supports_dynamic_schema": false,
- "supports_catalog": false,
- "supports_dynamic_catalog": false
- },
"Aurora MySQL": {
Review Comment:
Removing the Ascend engine also makes existing `ascend://` database
connections unusable after an upgrade, but there is no `UPDATING.md` entry
warning operators or naming a migration path. Could we document the removal and
the required remediation before this ships?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
