shivamgoel opened a new pull request, #43841:
URL: https://github.com/apache/superset/pull/43841
### SUMMARY
`docs/static/resources/openapi.json` is generated from the running app but
committed by hand, so it drifts silently. The last genuine regeneration before
#43788 was #33378, sixteen months earlier. This regenerates the spec on every
PR and fails on a dirty diff.
Two generation inputs are pinned deliberately, because getting either wrong
was a real failure while preparing #43788. The job installs
`requirements/base.txt`: apispec 6.10.0 renders marshmallow 4's `unknown=RAISE`
as `"additionalProperties": false` where the pinned 6.6.1 does not, so an
unpinned guard would fail every PR. And it passes no config file, so generation
reflects the routes a default deployment registers — a config with feature
flags enabled documents paths that 404 for everyone who hasn't enabled them.
No `paths:` filter, matching `enforce-single-migration-head`: a required
check that never runs on a PR blocks it forever. The job is ~10s.
### TESTING INSTRUCTIONS
Passes on unmodified `master` — the committed spec reproduces
byte-identically on the pinned requirements. To see it fail, add a field to any
marshmallow schema without regenerating:
```bash
SUPERSET__SQLALCHEMY_DATABASE_URI='sqlite:///:memory:' \
FLASK_APP='superset.app:create_app()' superset update-api-docs
git diff --stat -- docs/static/resources/openapi.json
```
Adding one schema renumbers apispec's auto-generated suffixes (`User1`,
`Subject1`), so diffs are routinely larger than the change.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
