codeant-ai-for-open-source[bot] commented on code in PR #43839:
URL: https://github.com/apache/superset/pull/43839#discussion_r3930238558
##########
superset-frontend/packages/superset-ui-core/src/time-format/utils/stringifyTimeInput.ts:
##########
@@ -25,11 +25,22 @@ export default function stringifyTimeInput(
return `${value}`;
}
+ let time: Date;
if (typeof value === 'string') {
const trimmed = value.trim();
const isIntegerString = /^-?\d+$/.test(trimmed);
- return fn(new Date(isIntegerString ? Number(trimmed) : value));
+ time = new Date(isIntegerString ? Number(trimmed) : value);
Review Comment:
**Suggestion:** Short numeric date strings such as `2017` are now treated as
millisecond timestamps, changing their meaning from January 2017 to a date near
the Unix epoch. [logic error]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=345cd00cc31c411a8ab269002f93c111&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=345cd00cc31c411a8ab269002f93c111&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/time-format/utils/stringifyTimeInput.ts
**Line:** 31:32
**Comment:**
*Logic Error: Short numeric date strings such as `2017` are now treated
as millisecond timestamps, changing their meaning from January 2017 to a date
near the Unix epoch.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43839&comment_hash=410f08ce04d21d621eb1bfa37606561569753a3611220af28409c29d4304761b&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43839&comment_hash=410f08ce04d21d621eb1bfa37606561569753a3611220af28409c29d4304761b&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
