raphaelsales commented on issue #43847: URL: https://github.com/apache/superset/issues/43847#issuecomment-5534696884
Happy to implement this. Concretely, I'd propose: treat a digits-only string as an epoch value only when it has enough digits to plausibly be one, and otherwise hand it to `new Date(value)` unchanged. Worth noting the current branch assumes **milliseconds**, so it is already narrower than it looks — a 10-digit epoch-*seconds* value like `1487071353` reads as 1970-01-18 today. Any threshold is a heuristic, so if you'd rather see this addressed in the dataset/column-format layer instead of in the parser, I'm happy to drop it — I'd just rather ask before writing the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
