amaannawab923 commented on PR #43820: URL: https://github.com/apache/superset/pull/43820#issuecomment-5540400379
quick follow up on the above. i had tested that against 3ae2f00 and missed the two commits that landed after it, so point 1 was already out of date when i posted. pulled the branch again and re-ran all three cases on 792a456. **point 1 (all negative column gets no colour) does not reproduce anymore.** the signed percent maximum change covers it. a non positive column maximum now makes the percent bound resolve to undefined and the scale falls back to the automatic data range, so the column renders a normal gradient instead of nothing. **points 2 and 3 still reproduce on the latest head**, re-checked just now: - percent of sum on 500 / -499 / 400 / -400 still gives north and east the exact same fully opaque red, and both negative rows still come out fully transparent. the sum branch still takes `Math.abs` of the total, and the signed sum of 1 passes the `<= 0` guard. - diverging with the center sitting on the maximum still falls back to the single hue scale, `isValidDivergingConfig` is unchanged. sorry for the noise on the first one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
