bito-code-review[bot] commented on code in PR #43876:
URL: https://github.com/apache/superset/pull/43876#discussion_r3934813553
##########
pyproject.toml:
##########
@@ -196,7 +196,7 @@ excel = ["xlrd>=2.0.2, <2.1"]
excel-export = ["boto3"]
fastmcp = [
"fastmcp>=3.4.7,<4.0",
- "mcp>=1.29.1,<3.0",
+ "mcp>=2.1.1,<3.0",
# tiktoken backs the response-size-guard token estimator. Without
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Dependency conflict</b></div>
<div id="fix">
This constraint conflicts with the pinned `fastmcp-slim==3.4.7`, which
requires `mcp<2.0,>=1.24.0` (PyPI metadata). `mcp>=2.1.1,<3.0` makes the
`fastmcp` extra unresolvable, and the lock file still pins `mcp==1.29.1`. Only
fastmcp 4.x supports mcp 2.x. Revert to `mcp<2.0` or bump fastmcp and migrate
`mcp_service`.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
fastmcp = [
"fastmcp>=3.4.7,<4.0",
"mcp>=1.29.1,<2.0",
# tiktoken backs the response-size-guard token estimator. Without
````
</div>
</details>
</div>
<small><i>Code Review Run #093bf9</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
