FrancescoCastaldi commented on PR #39724: URL: https://github.com/apache/superset/pull/39724#issuecomment-5542459586
@hainenber Thanks for the feedback! 1. **Windows shell flag comment & tests**: Added a clear explanatory comment above `_SHELL = os.name == "nt"` explaining that `"nt"` identifies Windows and `shell=True` allows `subprocess.run` to resolve `.cmd`/`.bat` wrappers (`npm.cmd`, `npx.cmd`, and executables in `node_modules/.bin`) without manual extension resolution. Also added a dedicated unit test in `compile_po_test.py`. 2. **Restored parallel PO conversion**: Restored `ThreadPoolExecutor` for converting `.po` files to `.json` concurrently across CPU cores. 3. **Regarding Docker**: While Docker is great for reproducible containerized environments, having a native Python script provides instantaneous, zero-overhead execution without requiring Docker daemon startup or container volume overhead. Since Python is already the native backend runtime in Superset development environments, this script aligns with existing native developer tooling in `scripts/` (such as `check_translation_regression.py`, `build_translation_index.py`, etc.) for seamless cross-platform local use across macOS, Linux, and Windows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
