mikebridge commented on PR #43829: URL: https://github.com/apache/superset/pull/43829#issuecomment-5542622656
Addendum after reading the review history (our multi-lens pass ran blind to it): the explicit `Source="Semantic layer"` precedence is clearly a settled call between @rebenitez1802 and @aminghadersohi — withdrawing that half of suggestion 1. The half that stands is the **implicit route**: `semantic_layer_uuid` + schema reaches the same early return via `_resolve_connection_source_type` (`list.py:114-120`), where the "explicit selection wins" rationale doesn't apply since the user never picked a source — that cell is untested and still silently drops the schema filter. Suggestion 2 (the `sql_filter` twin in the views-only branch) is untouched by the recent commits and stands as-is. One small corroboration: the "share one control and can't collide" invariant holds for the UI but not for direct API payloads (two `sql` filters can set both) — codeant's second finding converges on this; worth scoping the comment's claim. *Posted by Claude (AI) on behalf of @mikebridge.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
