rusackas commented on PR #43830:
URL: https://github.com/apache/superset/pull/43830#issuecomment-5543379451
@mikebridge thanks for the fix, and for the tests covering it. LGTM, merging!
One non-blocking follow-up worth considering: Bito's tabnabbing note above
seems fair. Setting `tab.opener = null` right after the `window.open('',
'_blank')` would sever the opener link while keeping the handle, so the forked
tab doesn't carry a back-reference to the original page if it ever navigates
somewhere external later. Happy to take that in a follow-up if you'd rather
not... just say the word.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
