eschutho opened a new pull request, #43884:
URL: https://github.com/apache/superset/pull/43884

   **Decisions made that were not in the instructions**
   None.
   
   ## What
   
   Datadog prod logs show recurring warning-level noise: `The 'md5' 
HASH_ALGORITHM is deprecated and retained only for backwards compatibility; 
prefer 'sha256' for namespace generation.` from `_uuid_namespace_from_md5` 
(`superset/key_value/utils.py`).
   
   This fires via `get_uuid_namespace_with_algorithm(seed, "md5")` from two 
fallback-lookup call sites whenever `HASH_ALGORITHM_FALLBACKS` (default 
`["md5"]`) resolves a legacy pre-SHA-256 entry:
   - 
`superset/commands/dashboard/permalink/create.py:CreateDashboardPermalinkCommand.run`
 -- a fallback hit does not migrate the legacy entry, so every future access of 
that permalink re-hits the md5 fallback and re-logs. Still indefinite.
   - `superset/key_value/shared_entries.py:get_shared_value` -- as of #42916 
(merged 2026-08-12), a fallback hit now persists a migrated current-algorithm 
entry, so this path logs at most once per legacy entry, not indefinitely.
   
   Either way, this is expected fallback behavior, not a one-off actionable 
event -- warning-level logging is the wrong severity for the repeat case.
   
   ## Change
   
   Downgrade the single `logger.warning` call in `_uuid_namespace_from_md5` to 
`logger.info`. No other behavior change -- the md5 hashing/namespace-generation 
logic itself is untouched. Mirrors the identical downgrade already applied to 
`QueryObject`'s deprecated-field warnings in #43520 for the same "expected, 
indefinite repeat" reasoning.
   
   ## Test plan
   
   - Updated `tests/unit_tests/key_value/utils_test.py` (renamed 
`test_uuid_namespace_from_md5_warns` -> 
`test_uuid_namespace_from_md5_logs_deprecation_at_info`) to assert 
`record.levelno == logging.INFO` explicitly, not just message content. Verified 
it fails if reverted to `logger.warning` and passes on this fix.
   - `uvx [email protected] check` and `format --check` clean on both changed files.
   - `pytest tests/unit_tests/key_value/utils_test.py` -- 24 passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to