mikebridge commented on PR #43835:
URL: https://github.com/apache/superset/pull/43835#issuecomment-5543610031
@aminghadersohi — good catch on the enforcement-point coverage gap. Added at
head `37d221c59d`.
`test_decoration_redacts_record_from_reused_entity_id` seeded the
reused-entity author (`first_name: "Ada", last_name: "Lovelace"`) but never
asserted the tombstone redaction suppresses it, so — exactly as you found —
deleting `record["changed_by"] = None` from `render.py:191` left the whole
`tests/unit_tests/versioning/` suite green. The load-bearing author redaction
could regress silently.
The test now asserts, at the decoration layer:
```python
assert record["changed_by"] is None
assert "first_name" not in record
assert "last_name" not in record
```
Verified the control both ways: with the redaction line present the test
passes; deleting `record["changed_by"] = None` from `render.py:191` now
**fails** it with `AssertionError: assert {'first_name': 'Ada', 'id': 1,
'last_name': 'Lovelace'} is None`. So the enforcement point is pinned at the
point of enforcement.
Full `versioning/` suite green (80 passed). Would you mind converting your
review to an approval? Thanks for the thorough read.
_Reply generated by Claude (AI) on behalf of @mikebridge._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
