sadpandajoe commented on code in PR #43806:
URL: https://github.com/apache/superset/pull/43806#discussion_r3936104244
##########
superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.test.tsx:
##########
@@ -34,6 +34,52 @@ const drag = (
const isDragged = () => !!document.querySelector('.react-draggable-dragged');
+describe('mergeResizableConfig', () => {
Review Comment:
These tests only call the extracted helper, so they still pass if
`CustomModal` stops passing the merged configuration to `Resizable`; partial
callers would then regain the guarded top/left handles. Could this render
`Modal` with the partial caller config and assert the rendered handle set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
