rusackas opened a new pull request, #43890: URL: https://github.com/apache/superset/pull/43890
### SUMMARY Regression test for the Treemap "vertical line inside every tile" symptom reported in #43862. The line came from a 1px `borderColor`/`borderWidth` on the label style. ECharts sizes the label's text box to the full node height (via the treemap view's `beforeUpdate` hook), so the box border rendered as a vertical line right after the label text, spanning the whole tile. #37808 removed the border and the symptom is gone on `master` (the reporter's screenshot also shows the inter-node gaps that #40181 removed, so their build predates both fixes; the border was still present in the 6.0.0 release). Nothing pinned that fix, so this adds a test that walks every `label` / `upperLabel` style in the transformed options (series, emphasis, levels, upper labels, and the filtered-node label) and asserts none of them declares a border. Verified the test fails if the old `borderColor`/`borderWidth` pair is reintroduced on `labelProps`, and passes on `master`. Rendered the pre-#37808 options with both ECharts 5.6.0 and 6.1.0 to confirm the mechanism; both draw the same line the reporter sees: <img width="760" alt="treemap label border artifact" src="https://github.com/user-attachments/assets/f4de4d10-a91b-4c39-8867-8664c47c4ef8"; /> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A, test-only. ### TESTING INSTRUCTIONS ``` cd superset-frontend npx jest --runInBand plugins/plugin-chart-echarts/test/Treemap/transformProps.test.ts ``` To see it fail, add `borderColor: theme.colorBgBase, borderWidth: 1` back to `labelProps` in `src/Treemap/transformProps.ts`. ### ADDITIONAL INFORMATION - [x] Has associated issue: #43862 (already fixed on `master` by #37808; this pins it) - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_015XdpWLXhUs7r8d4F2R5D6F -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
