rusackas commented on code in PR #327: URL: https://github.com/apache/superset-kubernetes-operator/pull/327#discussion_r3936484831
########## internal/controller/config_builder.go: ########## @@ -237,11 +237,21 @@ func resolveValkeyResults(spec *supersetv1alpha1.ValkeyResultsBackendSpec, defau // collectSecretEnvVars gathers env vars for SECRET_KEY, metastore fields, valkey, and the // instance name. The instance name is exposed so admins can compute instance-scoped values // (e.g. Celery queue names) from raw Python in spec.config. +// isDevEnvironment reports whether the CR is in Development mode. Inline secret Review Comment: Nit: this got inserted right under the `collectSecretEnvVars` doc comment, so godoc now attaches both paragraphs to `isDevEnvironment`. A blank line above (or moving the helper up a block) fixes it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
