mikebridge commented on code in PR #43781: URL: https://github.com/apache/superset/pull/43781#discussion_r3935841106
########## UPDATING.md: ########## @@ -39,6 +39,7 @@ payload. Clients must display the new impact and obtain renewed confirmation before retrying. Preview or recheck failures fail closed rather than treating unknown impact as zero. Chart and dashboard purge endpoints are unchanged. +- The dashboard datasource-based visibility fallback now fails closed: a dashboard whose member charts’ datasources cannot be resolved (deleted datasource rows, missing `datasource_id`, or unsupported datasource types) is no longer accessible to users without explicit editor/viewer rights, and a dashboard composed of semantic-view charts now requires `datasource_access` on (at least one of) its semantic views — previously any authenticated user could open such a dashboard’s shell. Dashboards with no charts remain accessible, and dashboards with explicit viewers are unaffected. Conversely, holders of `all_datasource_access` now see every published no-viewer dashboard in the dashboard list — including chart-less ones previously hidden by the inner joins — matching what the object-level gate already allowed them to open. Review Comment: Added in `e0dd7eb200` with your suggested wording, extended to the layer case: "Because the fallback now considers every member chart rather than only table-backed ones, a user holding `datasource_access` on any single member datasource — including a semantic view or its parent layer — can open a mixed dashboard that previously denied them." And confirmed intended, per your read: it's the pre-existing at-least-one-member semantics applied uniformly across datasource types; #43848 keeps the list surface aligned with it. Resolving. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
