rusackas commented on code in PR #43471: URL: https://github.com/apache/superset/pull/43471#discussion_r3936724046
########## superset/tags/core.py: ########## @@ -54,80 +54,40 @@ def _tag_delete_listener_declarations() -> tuple[DeleteListenerDeclaration, ...] def register_sqla_event_listeners() -> None: + """Register cleanup of ``tagged_object`` rows on object deletion. + + Only deletion is handled here: Superset no longer auto-generates Review Comment: Leaving them as-is on purpose, called it out in UPDATING.md: old rows stay queryable but go stale (no more freshness maintenance). Adding a migration to clear them felt riskier than useful given nothing in the UI ever surfaced these tags anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
