sadpandajoe commented on PR #42404: URL: https://github.com/apache/superset/pull/42404#issuecomment-5544673901
@rusackas — both items from your Aug 26 review should be resolved now: - The `down_revision` test mismatch was fixed in c27a14e0c8 (test now asserts `39097d124752`, matching the migration). - The `SqlEditor.test.tsx` failure you flagged as likely-unrelated flakiness hasn't recurred on subsequent CI runs. The branch has also been resynced with current `master` (previously blocked by a credential-scope issue on our push token, since resolved) and every other review thread on this PR is resolved. Would appreciate a re-review/dismissal when you have a moment so this can move forward — happy to address anything else that's changed since. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
