rusackas commented on PR #43732: URL: https://github.com/apache/superset/pull/43732#issuecomment-5546098926
@fparodimoraes nice catch, and the fix lines up with the repro in #43727. However, Copilot pointed out `init()` has no test coverage. Seems worth adding one that builds an unevenly-branched tree and checks each node's x stays inside its parent's band, since that's exactly what regressed here. Also, the CI runs on this got cancelled and never came back. That push should re-run CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
