rusackas commented on code in PR #43911:
URL: https://github.com/apache/superset/pull/43911#discussion_r3938682864
##########
superset-frontend/src/features/tasks/types.ts:
##########
@@ -69,6 +69,8 @@ export interface TaskPrivateProperties {
};
// Freeform task-type-specific handles (e.g.
cancel_query_id/cancel_database_id).
task?: Record<string, unknown>;
+ // Subscription-policy bookkeeping (e.g. chart-data's per-tab consumer list).
+ subscription?: Record<string, unknown>;
Review Comment:
Good catch, fixed! Added `subscription` to `PrivateProperties` and bumped
the docstrings to three namespaces. The `update_task_private` docstring was
still pointing policy bookkeeping at the wrong namespace too, so that got the
same treatment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
