codeant-ai-for-open-source[bot] commented on code in PR #43891:
URL: https://github.com/apache/superset/pull/43891#discussion_r3939218892
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx:
##########
@@ -1216,6 +1297,89 @@ function DatasourceEditor({
[],
);
+ // Which column's row expand to open, for the "map a different column" links.
+ // Consumed by the Columns tab, which scrolls the row into view and expands
it.
+ const [columnToReveal, setColumnToReveal] = useState<string | null>(null);
+
+ const handlePartitionColumnChange = useCallback(
+ (columnName: string | null) => {
+ setDatasource(prev => ({
+ ...prev,
+ partition_column: columnName,
+ // The override only means anything relative to a partition column, and
+ // leaving it behind would silently re-arm the next mapping.
+ partition_mapped_column: columnName
+ ? prev.partition_mapped_column
+ : null,
Review Comment:
**Suggestion:** Changing the partition column preserves an explicit mapped
column even when both names match, creating a self-mapping that backend
validation rejects. [incorrect condition logic]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1bafb6e75d1f47e1af9d90b7fee0bbcb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1bafb6e75d1f47e1af9d90b7fee0bbcb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
**Line:** 1311:1313
**Comment:**
*Incorrect Condition Logic: Changing the partition column preserves an
explicit mapped column even when both names match, creating a self-mapping that
backend validation rejects.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43891&comment_hash=fc2c6465c58613f7a624f7050876d0aeb04d9e35cf58e1db7b3ea3115752d38e&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43891&comment_hash=fc2c6465c58613f7a624f7050876d0aeb04d9e35cf58e1db7b3ea3115752d38e&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
