sadpandajoe commented on code in PR #43905: URL: https://github.com/apache/superset/pull/43905#discussion_r3939686444
########## docs/docs/using-superset/creating-your-first-dashboard.mdx: ########## @@ -379,6 +379,15 @@ AG Grid supports server-side column filters that query the full dataset — not AG Grid Interactive Table supports **Time Shift** (time comparison), matching the behavior of the standard Table chart. In the **Advanced Analytics** → **Time Comparison** section of the chart configuration, enter a shift expression (e.g., `1 year ago`, `minus 7 days`) to add comparison columns showing values from the offset period. Dashboard-level time range overrides apply to both the base and comparison periods. +#### Show Summary + +The **Show summary** checkbox lives at the top of the **Visual formatting** section in the **Customize** tab, for both **Aggregate** and **Raw Records** query modes. Enabling it pins a summary row to the bottom of the grid. + +- In **Aggregate** mode, the summary row applies each metric's own aggregation (or the **Summary aggregation** override, where available) across the full filtered dataset. +- In **Raw Records** mode, the summary row shows a server-side `SUM` for each numeric column that's backed by a physical or calculated dataset column; non-numeric cells and columns built from free-form SQL expressions stay blank. + +In both modes, the summary is computed across the full filtered result set, independent of the chart's row limit and pagination, and it reflects any active server-side column filters. Review Comment: This can make the footer disagree with the filtered grid: the totals query deliberately removes `agGridComplexWhere`, so an active server-side AG Grid column filter is not reflected in the summary. Could the text distinguish dashboard/chart filters from AG Grid column filters? ########## docs/docs/using-superset/creating-your-first-dashboard.mdx: ########## @@ -379,6 +379,15 @@ AG Grid supports server-side column filters that query the full dataset — not AG Grid Interactive Table supports **Time Shift** (time comparison), matching the behavior of the standard Table chart. In the **Advanced Analytics** → **Time Comparison** section of the chart configuration, enter a shift expression (e.g., `1 year ago`, `minus 7 days`) to add comparison columns showing values from the offset period. Dashboard-level time range overrides apply to both the base and comparison periods. +#### Show Summary + +The **Show summary** checkbox lives at the top of the **Visual formatting** section in the **Customize** tab, for both **Aggregate** and **Raw Records** query modes. Enabling it pins a summary row to the bottom of the grid. + +- In **Aggregate** mode, the summary row applies each metric's own aggregation (or the **Summary aggregation** override, where available) across the full filtered dataset. +- In **Raw Records** mode, the summary row shows a server-side `SUM` for each numeric column that's backed by a physical or calculated dataset column; non-numeric cells and columns built from free-form SQL expressions stay blank. Review Comment: Raw Records does not always use `SUM`: after enabling Show summary, selecting **Average** in Summary aggregation makes the totals query use `AVG`. Could this say that `SUM` is the default and that the selected summary aggregation is honored? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
