sadpandajoe commented on code in PR #43906:
URL: https://github.com/apache/superset/pull/43906#discussion_r3939753329


##########
docs/docs/using-superset/embedding.mdx:
##########
@@ -139,6 +139,25 @@ The following URL parameters can be passed through the 
`urlParams` option in `da
 
 ---
 
+## Embedding a Single Chart
+
+Individual charts can also be embedded standalone, outside of a dashboard, 
using a chart permalink. From Explore, generate a permalink for the chart, then 
append URL parameters to it:
+
+```
+/explore/p/<permalink-key>/?standalone=1&show_download=1
+```
+
+| Parameter       | Values   | Effect                                          
                           |
+| --------------- | -------- | 
-------------------------------------------------------------------------- |
+| `standalone`    | `0`, `1` | `0`: normal Explore view; `1`: hide the Explore 
header and controls        |
+| `show_download` | `0`, `1` | Show a compact download control (CSV, JSON, 
Excel) on the standalone chart |
+
+`show_download` is opt-in and has no effect outside of `standalone=1`. The 
download control still respects the viewer's `can_download` permission — it's 
hidden for users who lack it even when the parameter is set.

Review Comment:
   `can_download` is internal Explore state, not a grantable permission: it is 
derived from `can_export_data` with granular export controls or `can_csv` 
otherwise. An administrator who looks for `can_download` will still not expose 
this control—could this name the actual RBAC permissions and their feature-flag 
behavior?



##########
docs/docs/using-superset/embedding.mdx:
##########
@@ -139,6 +139,25 @@ The following URL parameters can be passed through the 
`urlParams` option in `da
 
 ---
 
+## Embedding a Single Chart
+
+Individual charts can also be embedded standalone, outside of a dashboard, 
using a chart permalink. From Explore, generate a permalink for the chart, then 
append URL parameters to it:
+
+```
+/explore/p/<permalink-key>/?standalone=1&show_download=1
+```
+
+| Parameter       | Values   | Effect                                          
                           |
+| --------------- | -------- | 
-------------------------------------------------------------------------- |
+| `standalone`    | `0`, `1` | `0`: normal Explore view; `1`: hide the Explore 
header and controls        |
+| `show_download` | `0`, `1` | Show a compact download control (CSV, JSON, 
Excel) on the standalone chart |
+
+`show_download` is opt-in and has no effect outside of `standalone=1`. The 
download control still respects the viewer's `can_download` permission — it's 
hidden for users who lack it even when the parameter is set.
+
+Unlike dashboard embedding above, this standalone chart URL is a plain page 
load rather than an iframe embed managed by `@superset-ui/embedded-sdk`, so it 
doesn't go through guest tokens or the `dashboardUiConfig` options.

Review Comment:
   Explore's Embed Code generates an `<iframe>` whose `src` is this permalink 
with `standalone=1`. Calling this a plain page load can lead integrators to 
omit the supported iframe embed—could this distinguish the 
session-authenticated iframe flow from the Embedded SDK/guest-token flow and 
show the iframe form?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to