FrancescoCastaldi commented on PR #43566:
URL: https://github.com/apache/superset/pull/43566#issuecomment-5550820915
@rusackas Sounds great to me! Merging this smaller PR first and then
rebasing #43695 on top is definitely the cleaner approach. I will take care of
rebasing #43695 as soon as this lands.
Regarding `default_port: 50000`: great catch! You are 100% right — it was
mistakenly inherited from Db2 LUW (`Db2EngineSpec`), which uses 50000 as its
default instance port.
Db2 for i (AS/400) does not use 50000:
- Under the hood, `sqlalchemy-ibmi` uses the IBM i Access ODBC driver
(`pyodbc`), which talks to the IBM i database server daemon (`as-database`,
`QZDASOINIT`) on port 8471 (or 9471 for TLS/SSL) via the port mapper
(`as-port-map`, 449), or 446/448 if using DRDA.
- More importantly, `sqlalchemy-ibmi`'s standard URI convention does not
expect a port in the host string
(`ibmi://{username}:{password}@{host}/{database}` — which matches what was
already in `Db2EngineSpec.metadata["compatible_databases"]`). Passing a port in
the host component can even cause the driver/dialect to fail.
I have just pushed a commit (`ba6c196`) that:
- Removes the inaccurate `default_port: 50000`
- Updates `connection_string` to
`ibmi://{username}:{password}@{host}/{database}`
- Removes `port` from `parameters`
- Updates `homepage_url` to `https://www.ibm.com/products/db2-for-i` and
adds `docs_url` / `sqlalchemy_docs_url`
Ready to merge whenever you are!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
