eschutho commented on PR #43464: URL: https://github.com/apache/superset/pull/43464#issuecomment-5555202524
Closing as superseded by #43407 (merged 2026-09-04, commit 8fb5b8f2fb — "migrate Global Async Queries onto the Global Task Framework"). That rewrite deleted `load_chart_data_into_cache` and the `async_query_manager` module entirely, replacing them with a GTF-based `execute_chart_query` task. There's nothing left to rebase this PR onto. More importantly, the specific bug this PR fixed — `ChartDataQueryFailedError`/`ChartDataCacheLoadError` re-raised as unhandled Celery errors instead of being reported cleanly — no longer reproduces: the new GTF worker (`superset/tasks/scheduler.py::_execute_task_body`) catches every exception from a task body and records a clean terminal `FAILURE` with a client-facing `error_message`, rather than letting it propagate as an unhandled task error. So this PR's fix is redundant against current master. One follow-up worth tracking separately (not blocking this close): the new GTF path doesn't distinguish client-class validation errors from genuine server errors — both get logged at `ERROR` with a traceback and counted under `gtf.task.failure`. If SUPERSET-PYTHON-13JV's volume was coming specifically from validation-class errors, the noise may resurface under a new fingerprint (e.g. under `superset.tasks.scheduler`) rather than actually being gone. That'd be new work scoped against `execute_chart_query`/the GTF task path, not a revival of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
