bito-code-review[bot] commented on code in PR #43876:
URL: https://github.com/apache/superset/pull/43876#discussion_r3943083926
##########
pyproject.toml:
##########
@@ -196,7 +196,7 @@ excel = ["xlrd>=2.0.2, <2.1"]
excel-export = ["boto3"]
fastmcp = [
"fastmcp>=3.4.7,<4.0",
- "mcp>=1.29.1,<3.0",
+ "mcp>=2.1.1,<3.0",
# tiktoken backs the response-size-guard token estimator. Without
Review Comment:
<!-- Bito Reply -->
The assessment that this dependency conflict is gated by a major migration
to fastmcp 4.x is correct. Given that the current lock file pins the dependency
to an older version, the suggestion provided by the reviewer is a valid
temporary constraint to maintain compatibility until the migration is performed.
**pyproject.toml**
```
fastmcp = [
"fastmcp>=3.4.7,<4.0",
"mcp>=1.29.1,<2.0",
# tiktoken backs the response-size-guard token estimator. Without
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
