sfirke opened a new pull request, #43940:
URL: https://github.com/apache/superset/pull/43940

   ### SUMMARY
   Currently when you have a single set of dashboard tabs, as you scroll down, 
the tabs are frozen to the top, providing the desired UX. But this does not 
currently apply to _nested_ tabs. This PR fixes that, adding two behaviors to 
nested tabs:
   1. They get stuck to the top
   2. When you click between nested tabs, there's now auto-scroll to the top. 
This problem was not evident until I fixed (1).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   **BEFORE (master branch 2026-09-04)**
   
   Note that I've scrolled down and the 2nd-level tabs have disappeared:
   
   <img width="943" height="452" alt="nested_tabs_frozen_before" 
src="https://github.com/user-attachments/assets/fb2afba8-807a-40b5-9071-0a46730b2a25";
 />
   
   
   **AFTER:**
   
   I have again scrolled down, now the 2nd level tabs are frozen and visible:
   
   <img width="938" height="486" alt="nested_tabs_frozen_after" 
src="https://github.com/user-attachments/assets/8f03f4da-a697-4b51-b32a-e4ab83387c7f";
 />
   
   Here I have scrolled down into content on a third level of tabs, still works:
   <img width="971" height="318" alt="image" 
src="https://github.com/user-attachments/assets/7a7e7160-9212-496c-ac0c-199594ef4298";
 />
   
   
   ### TESTING INSTRUCTIONS
   
   Create a dashboard with multiple levels of tabs, observe that they get stuck 
to the top when scrolling down and that clicking between nested tabs jumps you 
up to the top. I manually tested both.
   
   ### ADDITIONAL INFORMATION
   - [X] Changes UI
   
   I bounced this idea off of @rusackas a couple of months ago.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to