bito-code-review[bot] commented on PR #43941: URL: https://github.com/apache/superset/pull/43941#issuecomment-5560404050
<!-- Bito Reply --> The flagged issue regarding stale references during transport reinitialization is correct. When the transport is replaced globally, active polling waiters may continue using the old client instance, leading to inconsistent state or discarded updates. To resolve this, you should ensure that the transport is not replaced while active polling is in progress, or implement a mechanism to notify existing waiters to switch to the new transport instance. A common approach is to use a reference-counting mechanism or a state-management pattern that allows waiters to subscribe to transport updates, ensuring they always use the current, valid client. I have checked the available PR comments and there are no other actionable suggestions or comments to address in this PR. Would you like me to provide a more detailed implementation strategy for the transport update mechanism? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
