aminghadersohi commented on PR #43771: URL: https://github.com/apache/superset/pull/43771#issuecomment-5560883172
Finite maintainer disposition of Bito run #686bfa (six additional suggestions), implemented/reverified in bc8ac02f9a0dd3da8bdc3909079de1a99459efad: - **Extreme fractional Decimal profiling: addressed.** Bounded exponent/digit values retain an exact oversized-fraction identity instead of discarding all column sampling. `test_bounded_extreme_decimals_preserve_other_columns` checks both exponent signs and unrelated-column metadata. - **ASCII dimensions: addressed.** Rendered content is bounded by the requested width/height, with `test_ascii_preview_content_respects_requested_dimensions`. - **Aggregate alias comparison: addressed.** STDDEV/STDDEV_SAMP and VAR/VAR_SAMP compare using their mapped query semantics; `test_same_sunburst_metric_accepts_aggregate_aliases` covers both pairs. - **Stubbed repeated-metric validation: no production change needed.** The test's stub explicitly calls the real `GenerateChartRequest.model_validate(payload)`, so it does exercise `SunburstChartConfig.validate_roles`; it stubs the unrelated dataset pipeline, not Pydantic role validation. The registered FastMCP test and direct native request/update/explore matrices remain passing. - **Repeated pure-function call: addressed.** Primary metric identity is computed once. - **Ineffective SQL test monkeypatch: removed.** Dedicated complete-response boundary tests remain in place. Focused validation: **776 passed**. SQL/query suites: **51 passed**. Full branch-diff pre-commit (including MyPy, Ruff, Pylint and workflow checks) and staged pre-commit pass. Master was merged normally in `4dde97173719e8015647e59709023fee12f85f88`; Gauge registration/query-ordering and shared normalization contracts are preserved. Bullet #43770 was inspected read-only at `703bb6cd8c9a96c19e0e76c0b1e3ec968ec26489`; no Bullet branch/file/commit/PR was changed. No additional review session requested; final exact-head CI is being tracked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
