codeant-ai-for-open-source[bot] commented on code in PR #43883:
URL: https://github.com/apache/superset/pull/43883#discussion_r3945423198
##########
tests/unit_tests/models/test_virtual_dataset_format.py:
##########
@@ -472,3 +473,27 @@ def test_raises_when_rls_predicates_cannot_be_applied(
with pytest.raises(QueryObjectValidationError):
virtual_datasource.get_from_clause(template_processor=None)
+
+ @patch("superset.models.helpers.db")
+ @patch(
+ "superset.models.helpers.get_predicates_for_table",
+ return_value=["user_id = 42"],
+ )
Review Comment:
**Suggestion:** The mocked predicate lookup never touches the session, so
this test passes even if rollback happens after the fallback or the fallback
uses a poisoned session. [incomplete implementation]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Often`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=acea2c0d6d3942f3bb0f3185150247e2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=acea2c0d6d3942f3bb0f3185150247e2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/models/test_virtual_dataset_format.py
**Line:** 478:481
**Comment:**
*Incomplete Implementation: The mocked predicate lookup never touches
the session, so this test passes even if rollback happens after the fallback or
the fallback uses a poisoned session.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43883&comment_hash=f6c09ac507a4decb1e2d314141a9f0b04dd368ef92db623fb4eb30f758b8902a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43883&comment_hash=f6c09ac507a4decb1e2d314141a9f0b04dd368ef92db623fb4eb30f758b8902a&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
