codeant-ai-for-open-source[bot] commented on code in PR #43949:
URL: https://github.com/apache/superset/pull/43949#discussion_r3946949617
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx:
##########
@@ -612,26 +613,45 @@ const FilterControls: FC<FilterControlsProps> = ({
overflowedCrossFilters.length ||
(filtersOutOfScope.length && showCollapsePanel) ||
(customizationsOutOfScope.length && showCustomizationCollapsePanel)
- ? () => (
- <>
- <FiltersDropdownContent
- overflowedCrossFilters={overflowedCrossFilters}
- filtersInScope={overflowedFiltersInScope}
- filtersOutOfScope={filtersOutOfScope}
- renderer={renderer}
- rendererCrossFilter={rendererCrossFilter}
- showCollapsePanel={showCollapsePanel}
- forceRenderOutOfScope={hasRequiredFirst}
- />
- {showCustomizationCollapsePanel && (
- <CustomizationsOutOfScopeCollapsible
- customizationsOutOfScope={customizationsOutOfScope}
- renderer={customizationRenderer}
- forceRender={false}
+ ? (overflowedItems: DropdownItem[]) => {
+ // Which ids are overflowed comes from DropdownContainer's
own
+ // fresh, synchronous partition of `items` (the argument it
+ // passes here), not from `overflowedIds` state โ that state
+ // only updates one render later via
onOverflowingStateChange,
+ // so using it here could show a filter here that
+ // DropdownContainer's *own* main row, computed this same
+ // render, has already stopped excluding (duplicate chip).
+ const overflowedItemIds = new Set(
+ overflowedItems.map(item => item.id),
+ );
+ const freshOverflowedFiltersInScope = filtersInScope.filter(
+ ({ id }) => overflowedItemIds.has(id),
+ );
+ const freshOverflowedCrossFilters =
+ selectedCrossFilters.filter(({ emitterId, name }) =>
+ overflowedItemIds.has(`${name}${emitterId}`),
+ );
Review Comment:
**Suggestion:** When a chart customization overflows with a filter, this
callback renders only filters and cross-filters, so the customization
disappears from the More filters popover. [incomplete implementation]
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c27d2b5216f24b4ea93d5cd89ef093f8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c27d2b5216f24b4ea93d5cd89ef093f8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx
**Line:** 627:633
**Comment:**
*Incomplete Implementation: When a chart customization overflows with a
filter, this callback renders only filters and cross-filters, so the
customization disappears from the More filters popover.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43949&comment_hash=f3c5d4c8aef865f4dbea57b862976382bb776d2ed02b599a52ff83806053ab53&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43949&comment_hash=f3c5d4c8aef865f4dbea57b862976382bb776d2ed02b599a52ff83806053ab53&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
