bito-code-review[bot] commented on PR #43757:
URL: https://github.com/apache/superset/pull/43757#issuecomment-5565890715
<!-- Bito Reply -->
The current implementation deliberately separates validation into two tiers
to ensure that non-blocking issues (like a missing `:value` placeholder or an
unparseable transform) do not prevent the dataset from being saved. This design
choice, as documented in the code, allows users to save a "half-written"
transform without losing their other edits, leaving the mapping inactive until
it is fully valid.
While the summary could theoretically use the same validation result to
reflect the mapping's active status, the current approach prioritizes user
experience by allowing partial saves. The Explore indicator's behavior is
consistent with this design, as it reports the configuration as it is stored,
even if the mapping is currently inactive due to validation issues.
**superset/connectors/sqla/partition_mapping.py**
```
if not contains_value_placeholder(transform):
return [
MappingValidationIssue(
field=field,
message=_(
"The value transform must contain the :value
placeholder, "
"which stands for the filter value being mirrored."
),
blocking=False,
)
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
