bito-code-review[bot] commented on PR #43966:
URL: https://github.com/apache/superset/pull/43966#issuecomment-5571766258
<!-- Bito Reply -->
The flagged issue is correct. Because the `style` prop is applied directly
to the element, it can override the `max-width` and `overflow` properties
applied via the `css` template literal, potentially causing the transient row
to overflow during measurement.
To resolve this, you can ensure the styles are applied in a way that takes
precedence, for example by using `!important` within the `css` block or by
merging the styles more carefully. Given the current implementation, adding
`!important` is the most direct fix to ensure the layout constraints are
respected regardless of the consumer-provided `style` prop.
**superset-frontend/packages/superset-ui-core/src/components/DropdownContainer/DropdownContainer.tsx**
```
${
recalculating &&
css`
max-width: ${width}px !important;
overflow: hidden !important;
`
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
