beatum commented on PR #43705: URL: https://github.com/apache/superset/pull/43705#issuecomment-5578226979
> The service-worker.js COPY is missing from `Containerfile.podman` (line 218 just leaves the comment) — podman builds will 404 on it in production, per bito's flag. Also curious whether @hainenber's ask about one template across runtimes was considered instead of maintaining two Containerfiles/composes via a sed/python generator script. That's a lot of drift risk to take on. Thank you for catching the missing service-worker.js COPY. That was an oversight on my side, and i have fixed it. I also appreciate the recommendation to generate both runtime-specific files from one shared template. i agree that maintaining two Containerfiles and Compose files introduces drift risk. My initial reason for separating them was that podman, despite its strong Docker compatibility, still differs in some conventions and build behavior. For this change, I have kept the differences minimal. I am also open to moving toward a shared template and generator in a follow-up if that is the preferred direction for the project and i hope these small Podman-specific adjustments can still be useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
