drivaspreset commented on code in PR #43004:
URL: https://github.com/apache/superset/pull/43004#discussion_r3958928431
##########
.github/workflows/superset-playwright.yml:
##########
@@ -153,6 +153,30 @@
INCLUDE_MOBILE: "true"
with:
run: playwright-run "${{ matrix.app_root }}" mobile/
+ - name: Run Playwright (Global Async Queries Tests)
+ uses: ./.github/actions/cached-dependencies
Review Comment:
Thanks for flagging — this one's a false positive for this specific action.
.github/actions/cached-dependencies is a git submodule (see .gitmodules), not a
plain directory, and the $/... self-repository syntax resolves action files
straight from the repo without a real (submodule-aware) checkout — it can't see
into the submodule's gitlink, so switching this reference would break the step.
This is the same reasoning upstream already documented when converting other
local action refs to $/...: #43969 explicitly kept cached-dependencies on ./
for this exact reason, and only converted the plain-directory actions
(change-detector, setup-backend) alongside it. Dismissing as a false positive
to stay consistent with that precedent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
