mikebridge commented on code in PR #43490: URL: https://github.com/apache/superset/pull/43490#discussion_r3959815436
########## UPDATING.md: ########## @@ -63,6 +63,41 @@ payload. Clients must display the new impact and obtain renewed confirmation before retrying. Preview or recheck failures fail closed rather than treating unknown impact as zero. Chart and dashboard purge endpoints are unchanged. +- The purge audit log can now be pruned automatically. The new Review Comment: Fixed in `5706b963db`. You're right — the operator guide at line ~942 still asserted the `purge_audit_log` is "never pruned by design" and must be pruned manually, contradicting the automatic pruning this PR adds. I reworked that paragraph to describe the new policy accurately: automatic pruning via the `deletion_retention.prune_purge_audit` beat task, the earliest "blocked since" record in a live streak and completed-destruction evidence (`confirmed`/`target_absent`) preserved, only operational noise (`blocked` from resolved streaks + `failed`) aged out past `PURGE_AUDIT_RETENTION_DAYS`, and `PURGE_AUDIT_PRUNING_ENABLED = False` to restore the previous never-pruned behavior. The `## Next` release-note entry (line ~205) and the operator section now agree. Also in this push: rebased onto master and re-chained the pruning migration onto the current tip `7e2c9a4f1b83` (a sibling migration had merged onto the shared parent and created a second alembic head; `alembic-single-head` is green again). When you have a moment, could you re-review? Your three over-deletion findings are all addressed (the force-purge duplicate-prune fix in `0cba9314a7`/`d1c1f5e6c9`, plus the two proven-covered cases), and I'd rather this land on your approval than the stale one — the visible green is rusackas' approval from before those fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
