gabotorresruiz commented on PR #43805: URL: https://github.com/apache/superset/pull/43805#issuecomment-5589315718
Thanks for the approval! On the two optional items: the TZ test now pins TZ=Europe/Berlin in b80a6e02dd and I verified it fails against the reintroduced naive UTC bug before passing on the fix. On AccessDenied to FileNotFoundError I would keep it out of scope deliberately: mapping it would make a genuine permissions misconfiguration look like an expired link, which is much harder to debug than a 500 whose traceback names AccessDenied; the docs now prescribe s3:ListBucket so least privilege deployments get the clean 410. Happy to revisit if you feel strongly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
